Skip to content

🌐 Add Japanese translation for Contributing #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

komtaki
Copy link
Contributor

@komtaki komtaki commented Sep 17, 2020

This PR translates the contributing.md to Japanese.

According to the issue: #1572

Thanks!!

@komtaki komtaki mentioned this pull request Sep 17, 2020
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #2067 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2067   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c00618...a344daf. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit f6c4f7a at: https://5f6353961060439adbd3cda3--fastapi.netlify.app

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for good work. I propose some small correction and question.

@komtaki
Copy link
Contributor Author

komtaki commented Sep 18, 2020

@tokusumi

Thanks for the review!! 👍 I am embarrassed to many careless miss. 😓
I fixed everything. So, check my fix please.

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Never mind that. Finding careless mistakes is main task for reviewer.

@github-actions
Copy link
Contributor

📝 Docs preview for commit bec6364 at: https://5f642592e2535be097758834--fastapi.netlify.app

Copy link
Contributor

@Attsun1031 Attsun1031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your tough work !
I just made one comment, please check it out.

Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
@komtaki
Copy link
Contributor Author

komtaki commented Oct 10, 2020

@Attsun1031

Thank you for the suggestion.
I applied it. Check the fix please. 👍

@github-actions
Copy link
Contributor

📝 Docs preview for commit 67ee21e at: https://5f81a66f1a19b479500810a4--fastapi.netlify.app

Copy link
Contributor

@Attsun1031 Attsun1031 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Oct 15, 2020
@tiangolo tiangolo changed the title Add contributing.md Japanese ver. 🌐 Add Japanese translation for Contributing Oct 18, 2020
@tiangolo
Copy link
Member

Awesome, thank you @komtaki ! 🙇 ☕

And thanks @Attsun1031 and @tokusumi for the reviews 🤓 🍰

@tiangolo tiangolo merged commit bfc9733 into fastapi:master Oct 18, 2020
@komtaki komtaki deleted the translation/add-japanese-doc-contributing branch October 19, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants