- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
🌐 Add Japanese translation for Contributing #2067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Japanese translation for Contributing #2067
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2067 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 239 239
Lines 7079 7079
=========================================
Hits 7079 7079 Continue to review full report at Codecov.
|
📝 Docs preview for commit f6c4f7a at: https://5f6353961060439adbd3cda3--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for good work. I propose some small correction and question.
Thanks for the review!! 👍 I am embarrassed to many careless miss. 😓 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Never mind that. Finding careless mistakes is main task for reviewer.
📝 Docs preview for commit bec6364 at: https://5f642592e2535be097758834--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your tough work !
I just made one comment, please check it out.
Co-authored-by: atsumi <atsumi.tatsuya@gmail.com>
Thank you for the suggestion. |
📝 Docs preview for commit 67ee21e at: https://5f81a66f1a19b479500810a4--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Awesome, thank you @komtaki ! 🙇 ☕ And thanks @Attsun1031 and @tokusumi for the reviews 🤓 🍰 |
This PR translates the contributing.md to Japanese.
According to the issue: #1572
Thanks!!