- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Japanese translation for History Design and Future #2002
🌐 Add Japanese translation for History Design and Future #2002
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2002 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 239 239
Lines 7079 7079
=========================================
Hits 7079 7079 Continue to review full report at Codecov.
|
📝 Docs preview for commit 32f62e7cfd14750e2e7e876ca36a20cf12dd72bb at: https://5f4f61f91b2e0974afc3ac0a--fastapi.netlify.app |
32f62e7
to
0cba83c
Compare
📝 Docs preview for commit 0cba83c at: https://5f5267a6a13a211201097a70--fastapi.netlify.app |
Thanks for the review!! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
📝 Docs preview for commit 5054408 at: https://5f5db8ada9ea4d5136e47462--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your translation ! Most of the translation felt okay,
I commented only about the consistency with alternatives.md translation.
Thank you for your review. 👍 Please check my fix. |
📝 Docs preview for commit 78c5948 at: https://5f70578e4936ac987f449091--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍
Hi, @tiangolo |
I believe @tiangolo is currently moving houses, so you'll have to be patient |
Oops. I'm really sorry for annoying notification 🙇 |
Great! Thank you @komtaki ! 🙇 ☕ Thanks for the reviews @Attsun1031 and @tokusumi ! 🍰 🤓 And thanks @Mause for helping with the clarification! 😄 Indeed, finding a flat in Berlin is quite difficult and has a bunch of complications... I'm still waiting for the internet connection to be installed in my house 😅 But also thanks @tokusumi for pointing out the broken bot 🤦♂️ I wrote one to replace it and it should work fine from now on 🤖 🚀 |
This PR translates the history-design-future.md to Japanese.
According to the issue: #1572
Thanks!!