Skip to content

FIX: #998 resolves dependency overrides not working for websocket routes #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

amitlissack
Copy link
Contributor

@amitlissack amitlissack commented Mar 16, 2020

This resolves dependency overrides not working for websocket routes.

Includes tests in test_ws_router.

closes #998

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #1122 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1122   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         331     331           
  Lines        8085    8101   +16     
======================================
+ Hits         8085    8101   +16
Impacted Files Coverage Δ
fastapi/routing.py 100% <100%> (ø) ⬆️
tests/test_ws_router.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025b38d...fc61ef2. Read the comment docs.

@amitlissack amitlissack changed the title FIX: #998 FIX: #998 resolves dependency overrides not working for websocket routes Mar 29, 2020
@tiangolo tiangolo merged commit 02441ff into fastapi:master Mar 30, 2020
@tiangolo
Copy link
Member

Excellent job @amitlissack ! 👏 👏 Thanks for your contribution 🍰 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency override websocket broken
2 participants