Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My PR don't have the "approved-2" label #5561

Closed
9 tasks done
axel584 opened this issue Oct 31, 2022 · 6 comments
Closed
9 tasks done

My PR don't have the "approved-2" label #5561

axel584 opened this issue Oct 31, 2022 · 6 comments

Comments

@axel584
Copy link
Contributor

axel584 commented Oct 31, 2022

First Check

  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the FastAPI documentation, with the integrated search.
  • I already searched in Google "How to X in FastAPI" and didn't find any information.
  • I already read and followed all the tutorial in the docs and didn't find an answer.
  • I already checked if it is not related to FastAPI but to Pydantic.
  • I already checked if it is not related to FastAPI but to Swagger UI.
  • I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

  • I commit to help with one of those options 👆

Example Code

N/A

Description

I make a PR : #5477
And 2 persons already approve it : emmrichard and rjNemo
but the bot didn't add the approved-2 label.

Futhermore, some PR have this label and aren't merge to the master branch : https://github.com/tiangolo/fastapi/pulls?q=is%3Aopen+is%3Apr+label%3Aapproved-2

I'm pretty sure that I forgot something to do, but I don't know what.

Thank you for your advice.

Operating System

Linux

Operating System Details

N/A

FastAPI Version

0.85.1

Python Version

3.10

Additional Context

N/A

@axel584 axel584 added the question Question or problem label Oct 31, 2022
@iudeen
Copy link
Contributor

iudeen commented Oct 31, 2022

You can just comment this at that PR itself, instead of creating another issue. We already have many issues, I would suggest you to close and discuss PR related stuff within the PR.

@axel584
Copy link
Contributor Author

axel584 commented Oct 31, 2022

@iudeen : I understand, but If I add a comment in my PR, who will see it ? Only people who already aprove my PR.

I just want to know how the bot works to add the "approved-2" label.

@tiangolo
Copy link
Owner

tiangolo commented Nov 7, 2022

Hey there! Yep, the label is added only to PRs that have the labels for "lang-all" and "awaiting review". You did nothing wrong, I just hadn't added those labels.

Thanks for help @iudeen !

🍰☕

@axel584
Copy link
Contributor Author

axel584 commented Nov 7, 2022

Thanks!

@axel584 axel584 closed this as completed Nov 7, 2022
@tiangolo
Copy link
Owner

tiangolo commented Nov 7, 2022

Thanks for coming back to close the issue! ☕

@github-actions
Copy link
Contributor

Assuming the original need was handled, this will be automatically closed now. But feel free to add more comments or create new issues or PRs.

@tiangolo tiangolo reopened this Feb 27, 2023
Repository owner locked and limited conversation to collaborators Feb 27, 2023
@tiangolo tiangolo converted this issue into discussion #6171 Feb 27, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

3 participants