This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My PR don't have the "approved-2" label #5561
Comments
You can just comment this at that PR itself, instead of creating another issue. We already have many issues, I would suggest you to close and discuss PR related stuff within the PR. |
@iudeen : I understand, but If I add a comment in my PR, who will see it ? Only people who already aprove my PR. I just want to know how the bot works to add the "approved-2" label. |
Hey there! Yep, the label is added only to PRs that have the labels for "lang-all" and "awaiting review". You did nothing wrong, I just hadn't added those labels. Thanks for help @iudeen ! 🍰☕ |
Thanks! |
Thanks for coming back to close the issue! ☕ |
Assuming the original need was handled, this will be automatically closed now. But feel free to add more comments or create new issues or PRs. |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
First Check
Commit to Help
Example Code
Description
I make a PR : #5477
And 2 persons already approve it : emmrichard and rjNemo
but the bot didn't add the approved-2 label.
Futhermore, some PR have this label and aren't merge to the master branch : https://github.com/tiangolo/fastapi/pulls?q=is%3Aopen+is%3Apr+label%3Aapproved-2
I'm pretty sure that I forgot something to do, but I don't know what.
Thank you for your advice.
Operating System
Linux
Operating System Details
N/A
FastAPI Version
0.85.1
Python Version
3.10
Additional Context
N/A
The text was updated successfully, but these errors were encountered: