Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My PullRequest (translation of documentation) broke units tests... #5481

Closed
9 tasks done
axel584 opened this issue Oct 10, 2022 · 7 comments
Closed
9 tasks done

My PullRequest (translation of documentation) broke units tests... #5481

axel584 opened this issue Oct 10, 2022 · 7 comments
Labels
question Question or problem question-migrate

Comments

@axel584
Copy link
Contributor

axel584 commented Oct 10, 2022

First Check

  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the FastAPI documentation, with the integrated search.
  • I already searched in Google "How to X in FastAPI" and didn't find any information.
  • I already read and followed all the tutorial in the docs and didn't find an answer.
  • I already checked if it is not related to FastAPI but to Pydantic.
  • I already checked if it is not related to FastAPI but to Swagger UI.
  • I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

  • I commit to help with one of those options 👆

Example Code

N/A

Description

I translated a page of the documentation in french, and make a Pull Request :
#5477

And the CI/CD shows 2 problems with the Unit Test (for the 3.7 and 3.9 plateform) :
https://github.com/tiangolo/fastapi/actions/runs/3215376279/jobs/5256425256
https://github.com/tiangolo/fastapi/actions/runs/3215376279/jobs/5256425208

I don't understand why (I just add .md file).

The log explains :

        modulename = "anyio._backends._" + asynclib_name
        try:
>           return sys.modules[modulename]
E           KeyError: 'anyio._backends._trio'

/opt/hostedtoolcache/Python/3.9.14/x64/lib/python3.9/site-packages/anyio/_core/_eventloop.py:153: KeyError

Is it a missing module in the runner of the CI/CD ? To be honest, it's outside of my skills... Thanks for your help.

Operating System

Other

Operating System Details

the runner of the CI/CD :
https://github.com/tiangolo/fastapi/actions/runs/3215376279/jobs/5256425256
https://github.com/tiangolo/fastapi/actions/runs/3215376279/jobs/5256425208

FastAPI Version

0.85.0

Python Version

3.7 and 3.9

Additional Context

No response

@axel584 axel584 added the question Question or problem label Oct 10, 2022
@carlosm27
Copy link

Hey @axel584, thank you raise this issue. I have the same problem with pull request 5466. It is a Spanish translation and test 3.7 and test 3.9 fail. And I don't have any idea about the causes.

@mbroton
Copy link
Contributor

mbroton commented Oct 10, 2022

Hi, the cause of these problems is identified and fixed here: #5456
But it's not merged yet 😔

@axel584
Copy link
Contributor Author

axel584 commented Oct 12, 2022

@mbroton : Thank you very much. I hope your PR will merge soon.

@axel584 axel584 closed this as completed Oct 12, 2022
@Xewus
Copy link
Contributor

Xewus commented Oct 30, 2022

It seems, this problem (or very like) has moved to Python 3.9 - 3.10 .
I see it here #5336 (because its mine 😊)
and for another one #5550 .
Unfortunately, I do not understand this error 🐑

@iudeen
Copy link
Contributor

iudeen commented Oct 30, 2022

The failure is due to trio warning. Possible side effect of not pinning test deps.

@Xewus
Copy link
Contributor

Xewus commented Oct 31, 2022

Is it my fault?
I attached the translation of only one page and added one line for it in docs/ru/docs/deployment/index.md .
And last month there were no problems with this.
Earlier translations were fine too...

@iudeen
Copy link
Contributor

iudeen commented Oct 31, 2022

No, not your fault.

@tiangolo tiangolo reopened this Feb 27, 2023
Repository owner locked and limited conversation to collaborators Feb 27, 2023
@tiangolo tiangolo converted this issue into discussion #6149 Feb 27, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
question Question or problem question-migrate
Projects
None yet
Development

No branches or pull requests

6 participants