Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Fix Korean translation for docs/ko/docs/index.md #4195

Merged
merged 2 commits into from Jan 16, 2022

Conversation

kty4119
Copy link
Contributor

@kty4119 kty4119 commented Nov 20, 2021

Thank you always for your hard work.
I found something good to fix in this file.

  • Change the expression that doesn't match.
  • changed it according to the guidelines.

@hard-coders
Please check if this modification is appropriate and leave a comment.
Thank you for your hard work.

This PR complements docs/ko/docs/index.md
related : #2017

Copy link
Contributor

@DevDae DevDae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your works.
Please check my PR too! 😄

Copy link
Sponsor Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is following the rules better. Thank you for your effort.

@tiangolo tiangolo changed the title 🌐 Fix Korean translation for docs/ko/docs/index.md 🌐 Fix Korean translation for docs/ko/docs/index.md Dec 8, 2021
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Dec 8, 2021
@github-actions github-actions bot mentioned this pull request Dec 8, 2021
@NinaHwang
Copy link
Contributor

LGTM 🚀

@tiangolo
Copy link
Owner

Awesome, thank you @kty4119! 🍰

And thanks for the reviews @hard-coders, @NinaHwang, @DevDae. 🙇 ☕

@tiangolo tiangolo enabled auto-merge (squash) January 16, 2022 19:39
@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #4195 (9daf262) into master (0a61a6c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #4195     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          409       504     +95     
  Lines        10264     12707   +2443     
===========================================
+ Hits         10264     12707   +2443     
Impacted Files Coverage Δ
fastapi/utils.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
fastapi/openapi/docs.py 100.00% <0.00%> (ø)
...test_tutorial/test_dataclasses/test_tutorial002.py 100.00% <0.00%> (ø)
..._tutorial/test_sql_databases/test_sql_databases.py 100.00% <0.00%> (ø)
...orial/test_sql_databases/test_testing_databases.py 100.00% <0.00%> (ø)
docs_src/app_testing/main_b.py
docs_src/app_testing/test_main_b.py
...utorial/test_body_updates/test_tutorial001_py39.py 100.00% <0.00%> (ø)
docs_src/extra_models/tutorial005_py39.py 100.00% <0.00%> (ø)
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a61a6c...9daf262. Read the comment docs.

@tiangolo tiangolo merged commit 26e9411 into tiangolo:master Jan 16, 2022
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants