Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo/Bad wording in docs "FastAPI Path Parameters and Numeric Validations" page #3217

Closed
9 tasks done
ccrenfroe opened this issue May 12, 2021 · 5 comments
Closed
9 tasks done
Labels
question Question or problem question-migrate

Comments

@ccrenfroe
Copy link
Contributor

ccrenfroe commented May 12, 2021

First check

  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the FastAPI documentation, with the integrated search.
  • I already searched in Google "How to X in FastAPI" and didn't find any information. -- Unrelated
  • I already read and followed all the tutorial in the docs and didn't find an answer. -- Unrelated
  • I already checked if it is not related to FastAPI but to Pydantic. -- Unrelated
  • I already checked if it is not related to FastAPI but to Swagger UI. -- Unrelated
  • I already checked if it is not related to FastAPI but to ReDoc. -- Unrelated
  • After submitting this, I commit to one of:
    • Read open issues with questions until I find 2 issues where I can help someone and add a comment to help there.
    • I already hit the "watch" button in this repository to receive notifications and I commit to help at least 2 people that ask questions in the future.
    • Implement a Pull Request for a confirmed bug.

Description

I believe there is a typo in the docs here! In the info box under the recap section, it states the following:

Query, Path, and others you will see later are subclasses of a common Param class (that you don't need to use).
And all of them share the same all these same parameters of additional validation and metadata you have seen.

Seems a bit hard to read, no?

@ccrenfroe ccrenfroe added the question Question or problem label May 12, 2021
@ccrenfroe ccrenfroe changed the title [Doc Errors] Typo/Bad wording in docs [Doc Errors] Typo/Bad wording in docs "FastAPI Path Parameters and Numeric Validations" page May 12, 2021
@Kludex
Copy link
Sponsor Collaborator

Kludex commented May 12, 2021

What do you suggest?

What do you think about the following:

"Query, Path, and others classes you will see later are subclasses of Param class (that you don't need to use).
And All of them share the same all these same parameters for of additional validation and metadata, that you have already seen."

Maybe removing also this "that you have already seen"?

Either way, a PR should be welcome, the current text is really confusing. 😅

@ccrenfroe
Copy link
Contributor Author

I think that would work great! That is much more clear to me. 😄

So far, I think the text has been very nice, especially as someone new to developing APIs.

I'll gladly put up a PR for this if that is alright?

@Kludex
Copy link
Sponsor Collaborator

Kludex commented May 12, 2021

I'll gladly put up a PR for this if that is alright?

I don't have merge rights, but I think it will be highly appreciated! :)

@ccrenfroe
Copy link
Contributor Author

ccrenfroe commented May 13, 2021

I put up a PR for the doc change. I'll go ahead and close this issue since it has been addressed and a change proposed.

Thanks for your time and suggestion! ✌️

@tiangolo
Copy link
Owner

Thanks for the help here @Kludex ! 👏 🙇

Thanks for reporting back and closing the issue @ccrenfroe 👍

Sorry for the long delay! 🙈 I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.

@tiangolo tiangolo changed the title [Doc Errors] Typo/Bad wording in docs "FastAPI Path Parameters and Numeric Validations" page Typo/Bad wording in docs "FastAPI Path Parameters and Numeric Validations" page Feb 24, 2023
@tiangolo tiangolo reopened this Feb 27, 2023
Repository owner locked and limited conversation to collaborators Feb 27, 2023
@tiangolo tiangolo converted this issue into discussion #6635 Feb 27, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
question Question or problem question-migrate
Projects
None yet
Development

No branches or pull requests

3 participants