Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starlette 0.14.2 issue with fastAPI due to deprecation of UJSONResponse #3045

Closed
L1ghtn1ng opened this issue Apr 6, 2021 · 5 comments
Closed
Labels
question Question or problem question-migrate

Comments

@L1ghtn1ng
Copy link

From me having a look at what is importable in starlette it needs to use JSONResponse not UJSONResponse as that seems to have been removed
image

Would be good to get this fixed ASAP and a new release pushed out to fix this issue as need to use this version of starlette and due to fastapi not having support for this version of starlette is being a release blocker for me

@L1ghtn1ng L1ghtn1ng added the question Question or problem label Apr 6, 2021
@Kludex
Copy link
Sponsor Collaborator

Kludex commented Apr 6, 2021

#2342
#2493
#2335

@L1ghtn1ng
Copy link
Author

Doh missed these, can we go about increasing its priority to get this resolved?

@Kludex
Copy link
Sponsor Collaborator

Kludex commented Apr 6, 2021

This will probably be addressed by the end of the month.

But, as I said before on one of those issues: just don't pin Starlette. FastAPI already installs the right Starlette version.

Btw, as it is a duplicated issue, do you mind closing it?

@L1ghtn1ng
Copy link
Author

with the version that fastapi installs unfortunately has missing imports that are in newer versions that I need and yeah sure will close it

@tiangolo
Copy link
Owner

Thanks for the help here @Kludex ! 👏 🙇

Thanks for reporting back and closing the issue @L1ghtn1ng 👍

Sorry for the long delay! 🙈 I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.

@tiangolo tiangolo changed the title [BUG] starlette 0.14.2 issue with fastAPI due to deprecation of UJSONResponse starlette 0.14.2 issue with fastAPI due to deprecation of UJSONResponse Feb 24, 2023
@tiangolo tiangolo reopened this Feb 27, 2023
Repository owner locked and limited conversation to collaborators Feb 27, 2023
@tiangolo tiangolo converted this issue into discussion #6766 Feb 27, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
question Question or problem question-migrate
Projects
None yet
Development

No branches or pull requests

3 participants