Skip to content

improve test debugging #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Conversation

samuelcolvin
Copy link
Collaborator

related to #1221

For simplicity this is solely the result of running the following regex find a replace

"(response\.status_code == \d+)$" -> "$1, response.text"

on /tests/

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #1222 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1222   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          226       226           
  Lines         6783      6783           
=========================================
  Hits          6783      6783           
Impacted Files Coverage Δ
tests/test_additional_properties.py 100.00% <100.00%> (ø)
tests/test_additional_response_extra.py 100.00% <100.00%> (ø)
...est_additional_responses_custom_validationerror.py 100.00% <100.00%> (ø)
...st_additional_responses_default_validationerror.py 100.00% <100.00%> (ø)
tests/test_additional_responses_response_class.py 100.00% <100.00%> (ø)
tests/test_additional_responses_router.py 100.00% <100.00%> (ø)
tests/test_application.py 100.00% <100.00%> (ø)
tests/test_custom_swagger_ui_redirect.py 100.00% <100.00%> (ø)
tests/test_dependency_cache.py 100.00% <100.00%> (ø)
tests/test_dependency_class.py 100.00% <100.00%> (ø)
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 483bce3...c324ea1. Read the comment docs.

@samuelcolvin
Copy link
Collaborator Author

also netlify builds seem to be failing 😴 🔫 .

@tiangolo tiangolo force-pushed the improve-test-debugging branch from 00a8420 to c324ea1 Compare April 8, 2020 04:34
@tiangolo tiangolo merged commit e9b189e into fastapi:master Apr 8, 2020
@tiangolo
Copy link
Member

tiangolo commented Apr 8, 2020

Thanks! ✔️ 🚀

@samuelcolvin samuelcolvin deleted the improve-test-debugging branch April 8, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants