Add support for PEP695 TypeAliasType #11140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kind of unhappy with the amount of hoopsI jump through to not let coverage/pytest really see the test code, as it is a true SyntaxError in all python Version before 3.12. Maybe there is a better idea? |
dev-loki
commented
Feb 13, 2024
Comment on lines
+3
to
+4
| if sys.version_info < (3, 12): | ||
| collect_ignore_glob = ["*_py312.py"] |
There was a problem hiding this comment.
Shall we add that to the previous versions too?
dev-loki
commented
Feb 13, 2024
Comment on lines
+10
to
+12
| needs_py312 = pytest.mark.skipif( | ||
| sys.version_info < (3, 12), reason="requires python3.12+" | ||
| ) |
There was a problem hiding this comment.
Tbh I would prefer adding that as a custom mark:
In conftest.py:
import sys
def pytest_runtest_setup(item):
for mark in item.iter_markers():
if mark.name == 'py312' and sys.version_info < (3, 12):
pytest.skip("Cannot run on python versin < 3.12")
...This would change the test code to:
import pytest
@pytest.mark.py312
def test_only_executed_on_python_312_and_above():
assert sys.version_info >= (3, 12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10719
Discussed (by others) in: #10662
Adds support for PEP695.
Sidesupport (please check if intended!): Only loads
*_py312files for python3.12 and later, as only the test introduces syntax not compatible for python < 3.12.Using
DependedVariablein route dependencies will now work :).