-
Yesterday, Starlette 0.14.1 was released, which removes Line 10 in b53c443 |
Beta Was this translation helpful? Give feedback.
Replies: 14 comments
-
Here is the related PR #2335 |
Beta Was this translation helpful? Give feedback.
-
Thank you for the pointer @ycd . I'll keep the issue open until the PR merges, for reference for users whose servers break (like mine did). |
Beta Was this translation helpful? Give feedback.
-
What's the smartest thing to do here? |
Beta Was this translation helpful? Give feedback.
-
@mezhaka Not importing |
Beta Was this translation helpful? Give feedback.
-
Yes, until #2335 merges, the Starlette version needs to be pinned to <0.14.1 if you have it in your requirements. @Kludex , for most people that will do. But it is worth noting that may not be an option if you directly use some of Startlette's elements and need to have an updated version. Keep in mind that right now FastAPI installs by default Starlette 0.13.6, which is 4 releases behind master. |
Beta Was this translation helpful? Give feedback.
-
@Kludex @miguescri I did not have explicit Starlette in my environment and this way the app was broken. As I have added it explicitly -- it runs. |
Beta Was this translation helpful? Give feedback.
-
Which package manager are you using? If you don't add an explicit dependency version, it should automatically install a compatible version |
Beta Was this translation helpful? Give feedback.
-
@mezhaka are you using a virtual env or a system wide installation? And are you using a Python package manager or you installed some of the Python packages from your distro's repositories? |
Beta Was this translation helpful? Give feedback.
-
@Mause @miguescri I use conda. I have an environment.yml file which looks something like this (I've removed some packages): name: myapp
channels:
- conda-forge
- mycompany
dependencies:
- python~=3.7
- pymongo~=3.10
- gunicorn~=20.0
- uvicorn~=0.11
- fastapi~=0.60
- pydantic~=1.6 I then create environments with |
Beta Was this translation helpful? Give feedback.
-
Btw, i'm still not sure this error is an expected behaviour, because in our Line 35 in 52dd592 Starlette pinned to the |
Beta Was this translation helpful? Give feedback.
-
I also ran into problems with my Conda environment. FastAPI pins I reported it to the feedstock here: |
Beta Was this translation helpful? Give feedback.
-
#2335 has been merged. |
Beta Was this translation helpful? Give feedback.
-
Thanks for the help here everyone! 👏 🙇 Thanks for reporting back and closing the issue @miguescri 👍
|
Beta Was this translation helpful? Give feedback.
-
Assuming the original need was handled, this will be automatically closed now. But feel free to add more comments or create new issues or PRs. |
Beta Was this translation helpful? Give feedback.
#2335 has been merged.