From 46974c510e89c35456f40ca35d432fe0b94e0f97 Mon Sep 17 00:00:00 2001
From: Eugenio Panadero <eugenio.panadero@gmail.com>
Date: Sun, 27 Nov 2022 15:46:06 +0100
Subject: [PATCH] =?UTF-8?q?=E2=AC=86=20Bump=20Starlette=20to=20version=20`?=
 =?UTF-8?q?0.22.0`=20to=20fix=20bad=20encoding=20for=20query=20parameters?=
 =?UTF-8?q?=20in=20`TestClient`=20(#5659)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

closes https://github.com/tiangolo/fastapi/issues/5646
---
 pyproject.toml                        |  2 +-
 tests/test_starlette_urlconvertors.py | 14 +++++++++++++-
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/pyproject.toml b/pyproject.toml
index 4ae3809864b2a..06f8a97b2e0e3 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -39,7 +39,7 @@ classifiers = [
     "Topic :: Internet :: WWW/HTTP",
 ]
 dependencies = [
-    "starlette==0.21.0",
+    "starlette==0.22.0",
     "pydantic >=1.6.2,!=1.7,!=1.7.1,!=1.7.2,!=1.7.3,!=1.8,!=1.8.1,<2.0.0",
 ]
 dynamic = ["version"]
diff --git a/tests/test_starlette_urlconvertors.py b/tests/test_starlette_urlconvertors.py
index 5a980cbf6dad7..5ef1b819cda70 100644
--- a/tests/test_starlette_urlconvertors.py
+++ b/tests/test_starlette_urlconvertors.py
@@ -1,4 +1,4 @@
-from fastapi import FastAPI, Path
+from fastapi import FastAPI, Path, Query
 from fastapi.testclient import TestClient
 
 app = FastAPI()
@@ -19,6 +19,11 @@ def path_convertor(param: str = Path()):
     return {"path": param}
 
 
+@app.get("/query/")
+def query_convertor(param: str = Query()):
+    return {"query": param}
+
+
 client = TestClient(app)
 
 
@@ -45,6 +50,13 @@ def test_route_converters_path():
     assert response.json() == {"path": "some/example"}
 
 
+def test_route_converters_query():
+    # Test query conversion
+    response = client.get("/query", params={"param": "Qué tal!"})
+    assert response.status_code == 200, response.text
+    assert response.json() == {"query": "Qué tal!"}
+
+
 def test_url_path_for_path_convertor():
     assert (
         app.url_path_for("path_convertor", param="some/example") == "/path/some/example"