pyyaml version pinning leads to conflic with fermipy

[henrikef]

We require pyyaml version 3.13:

astromodels/setup.cfg

Line 38 in 3a02b82

PyYAML==3.13

See #97 for why things break with newer versions of pyyaml.

Unfortunately, fermipy requires gammapy, which has required pyyaml >=5.1 for about a year now (and I believe that newer versions of fermipy are incompatible with older gammapy versions).

So, I believe it's time to try again to get astromodels working with newer versions of pyyaml. Has anyone looked into this at all?

[ndilalla]

Hi @henrikef! Yes, I am working on this on the development branch for the new fermitools and root6. Astromodels is ready to work with newer pyyaml while in threeML I am still having some issues with the YAML loader that is deprecated in pyyaml 5.1. So we will need to change a bit our code according to this:
https://github.com/yaml/pyyaml/wiki/PyYAML-yaml.load(input)-Deprecation

[henrikef]

Awesome! Let me know if you need any help or would like me to test anything.

[grburgess]

I noticed when I tried to modify to the forward version pyyaml that the safe loader was not compatible with our model structure. Is that still the case?

[henrikef]

What about the "FullLoader" or "UnsafeLoader" though?

[grburgess]

@henrikef I think I tried that.. but I cannot remember. @ndilalla how did you get it to work?

[ndilalla]

@henrikef I think I tried that.. but I cannot remember. @ndilalla how did you get it to work?

Locally I used FullLoader and everything seems to work. Unfortunately it breaks the compatibility with pyyaml 3.13. If we want to be still compliant we will have to do something smarter (like checking the pyyaml major version first). What do you think about it?

[henrikef]

Is there a problem requiring a newer version of pyyaml? I vote for no backward compatibility.

[grburgess]

I second :)

…

On Oct 13, 2020, at 18:17, Henrike F ***@***.***> wrote: Is there a problem requiring a newer version of pyyaml? I vote for no backward compatibility. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#131 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABTTLZ5AB7N6RXQDKDDBGT3SKR4TFANCNFSM4SH7SP5Q>.

[ndilalla]

No, no problems. We just need to require pyyaml >= 5.1 in the dependency list. I'll go for it.

[ndilalla]

I don't know why the stupid conda continues to put pyyaml==3.13 as requirement even if I've put pyyaml>=5.1 in the meta and setup files! This is crazy...

[ndilalla]

Okay, it should be fixed now.