Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support turbo (and drop support for turbolinks classic, keep support for turbolinks5) #933

Open
timdiggins opened this issue Feb 25, 2022 · 0 comments

Comments

@timdiggins
Copy link
Collaborator

timdiggins commented Feb 25, 2022

We have code that works against Turbolinks5 vs Tubolinks 4 ("Classic") vs no-turbolinks.
e.g. on_page_load.es6

With the release of Turbo (Turbo Drive, is the relevant component), I think we should be supporting and testing against Turbo as well as the last release of legacy Turbolinks (i.e Turbolinks 5.2.0 or 5.3.0-beta.1)

Suggested grid:

  • 6.0 x Turbolinks
  • 6.1 x Turbolinks
  • 7.0 x both Turbolinks and Turbo Drive
  • main x Turbo Drive only

(what about no turbolinks/turbo at all - we probably need to test this if we're supporting it, though we're not testing it at present).

Maybe we should consider duplicating the dummy app and make it dependent on Turbo::Drive but also making it use the rail 7 webpack-less approach to javascript. (in the same way as we have been supporting separately testing sprockets and webpack).

@timdiggins timdiggins changed the title Support turbo (and drop support for turbolinks 4, keep support for turbolinks5) Support turbo (and drop support for turbolinks classic, keep support for turbolinks5) Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant