Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Migration spec for 07 to 08 #443

Closed
wants to merge 28 commits into from
Closed

[WIP] Migration spec for 07 to 08 #443

wants to merge 28 commits into from

Conversation

timdiggins
Copy link
Collaborator

Very much work in progress, but will close #437 when done.

(This is currently testing and dependent on #441 so there are a lot of irrelevant commits at the beginning -- will need to be rebased before merge)

  • move sample 0.7 sqlite file to a separate dump file
  • allow a clean up to allow for smoke test and specific tests.
  • maybe try to split apart normal spec_helper and migration spec_helper for clarity?
  • write up how to create dump file (for 0.8 for example)

EllaNancyFay and others added 27 commits October 31, 2016 08:50
@timdiggins
Extrat email notifications out of thredded
e6f163f
@timdiggins
adjust responsibilities between NotifyFollowingUsers and EmailNotifier
300c371
@timdiggins
remove unneeded file
df464f9
@timdiggins
shift responsibilities out of EmailNotifier and back into NotifyPriva…
0b676ba 
…teTopicUsers
@timdiggins
remove .new from notifier
9dc3b87
@timdiggins
add resetter to TestNotifier
7733140
@timdiggins
rename TestNotifier to MockNotifier
214bb11
@timdiggins
[WIP] pending and commented tests (preference fields per notifier)
4f8f3fc
@timdiggins
instanciate notifer on initalize
bf85914
@timdiggins
preference field hash for followed / private topics
3ff7f08
@timdiggins
make commands respect the pref fields
3808a5e
@timdiggins
migration to remove old preference fields
5fea4cf
@timdiggins
fix db pref migrations by moving to right place and tweaking.
4531401 
null: false, so they are neve null.
remove unneeded messageboard pref for private topics
@timdiggins
UI allows preferences per notifier
069cde1
@timdiggins
fix setting preferences and move data mangling to controller
e2dffae
@timdiggins
fix javascripts for multiple notifiers
8727765
@timdiggins
tweak styles
7778cc4
@timdiggins
indicate how to try out multiple notifiers in dummy initializer
44005b2
@timdiggins
rubocop fixes
d11d20f
@timdiggins
namespace TruthyHash::Serializer differently
8381e43
@timdiggins
add data change to upgrade migration
7735a81
@timdiggins
add sample data for 0.7 base for migration spec
ad969b9
@timdiggins
basic migration fixture
5267541
@timdiggins
add to travis
f4f636d
@timdiggins
test for migration change fix
1cee723
@timdiggins
fix travis execution
612b5a6
@timdiggins
ensuring tmp exists
269481a
@glebm
Copy link
Collaborator

glebm commented Nov 13, 2016

Punt this to v0.9.0 as I want to release v0.8.0 today, since the project is getting a lot of new users and there is a lot of good stuff in the current master and some backwards-incompatible changes too.

@timdiggins
Copy link
Collaborator Author

I've now integrated this into #442 because I needed it there.

@timdiggins timdiggins closed this Nov 18, 2016
@timdiggins timdiggins deleted the migration-spec-for-07-to-08 branch November 18, 2016 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Smoke test for migrations
3 participants
@timdiggins @glebm @jayroh