-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topics in index should link to most recently read topic (anchor), rather than just the page of that topic #362
Comments
I think we are. It also works for me on https://thredded.org/thredded/main-board. |
@glebm agreed, have understood where it happens in the view model now. I was thinking (in addition to linking to the page as we are doing) we should link to the anchor of the last read post if possible. This anchor should be calculated and stored in UserTopicReadState. |
from #533:
@jayroh I know you've had some thoughts about this -- maybe about doing it in Javascript w/scrollspy for example ( I'm less keen on this, even though it is less accurate, seems like it could be nightmarish to support) |
@timdiggins Yeah your estimation is right on. This is the "best" way to track all of this but it's no easy task as there's a lot to juggle. On topics#show - the topic, page, and post Then of course there's topics#index - marking read or un-read on all of those. JS is the best way to do this and in terms of support, as long as it's well tested it should be relatively manageable. |
I'm in favour of a simple approach as the next step:
|
decision on #535 is relevant to putting a "unread posts below here" in the UI. |
+1
#536 is a pre-requisite for adding the marker, so I'll merge it tomorrow if there are no objections.
+1 |
Given that we store the page of the most recently read page, shouldn't we be linking to this page in the topics#index ?
The text was updated successfully, but these errors were encountered: