Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom has_secure_password attributes #1356

Merged
merged 1 commit into from Sep 14, 2020
Merged

Support custom has_secure_password attributes #1356

merged 1 commit into from Sep 14, 2020

Conversation

krismichalski
Copy link
Contributor

Starting with version 6, Rails accepts custom attributes for has_secure_password macro.
Without one it defaults to password, so everything should still work without breaking for older versions of Rails as well.

Rails pull request for allowing configurable attribute name on #has_secure_password - rails/rails#26764

Starting with version 6, Rails accepts custom attributes for
has_secure_password macro. Without one it defaults to `password`,
so everything should still work without breaking for older versions of
Rails as well.
Copy link
Collaborator

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants