Add have_implicit_order_column matcher #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaorlov
force-pushed
the
feature/have_implicit_order_column
branch
from
4d601c4
to
ea7261f
Compare
mcmire
reviewed
Dec 8, 2019
lib/shoulda/matchers/active_record/have_implicit_order_column.rb
Outdated
Show resolved
Hide resolved
lib/shoulda/matchers/active_record/have_implicit_order_column.rb
Outdated
Show resolved
Hide resolved
spec/unit/shoulda/matchers/active_record/have_implicit_order_column_spec.rb
Outdated
Show resolved
Hide resolved
yaorlov
force-pushed
the
feature/have_implicit_order_column
branch
2 times, most recently
from
6e58ca7
to
1b70d39
Compare
yaorlov
force-pushed
the
feature/have_implicit_order_column
branch
from
1b70d39
to
178e80b
Compare
|
any news @mcmire ? :) i really need this PR to test |
|
Yup, so sorry @cprodhomme. I think this is ready to go but I will take another look at this later today. |
mcmire
force-pushed
the
feature/have_implicit_order_column
branch
from
178e80b
to
a024f4c
Compare
Add a matcher that can test the new [implicit_order_column][1] class property that is available on ActiveRecord classes in Rails 6. [1]: rails/rails#34480 Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
mcmire
force-pushed
the
feature/have_implicit_order_column
branch
from
5b6fc32
to
f82329a
Compare
|
Thanks for this PR! I took some liberties in bringing this up to current standards and in tweaking the error message a bit. It's in master now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
have_implicit_order_columnmatcher to test rails 6 implicit_order_column