Deprecate order and conditions qualifiers on association matchers

[mcmire]

Historically, the association matchers have had order and conditions qualifiers for testing associations with custom relations. These qualifiers stem from old-style ActiveRecord associations where you could specify order or conditions options to fine-tune the results you'd get back when querying for the association. These have long been replaced with an argument that takes an ActiveRecord::Relation (wrapped in a lambda). However, the matchers in shoulda-matchers have not been updated to match.

That means that currently, if you have an association with a custom relation, there's no way to test that in shoulda-matchers. People have raised GitHub issues about this over time -- see #549, #774, #810, and #952.

Personally, I think we should deprecate and eventually remove order and conditions. I feel like as soon as you add a custom relation to your association, you are adding custom logic to your code, and as such this logic -- the query that's generated -- needs to be tested manually, not by using a matcher.

So I think we could lay this issue to rest by deprecating these qualifiers and adding a section to each of the association matchers about testing associations with conditions.

[mcmire]

This is a good idea, but it's much lower priority than the current issues. I'm going to close this in the meantime.