Bring CHANGELOG up to date #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
approved these changes
Jun 3, 2021
CHANGELOG.md
Outdated
| ### Backward-incompatible changes | ||
|
|
||
| * Drop support for Rails 4.2, 5.0 and 5.1 as well as Ruby 2.4 and 2.5 | ||
| they've been end-of-lifed. The gem now supports Ruby 2.6+ and Rails 5.2+.([#1412], [#1415], [#1422], [#1428],[#1429]) |
There was a problem hiding this comment.
Should you have a space after the period?
CHANGELOG.md
Outdated
| ### Features | ||
|
|
||
| * Add support for Rails 6.1. No new Rails 6.1 features are supported, but only | ||
| existing features that broke with the upgrade.([#1418]) |
There was a problem hiding this comment.
Should you have a space after the period?
CHANGELOG.md
Outdated
|
|
||
| ### Bug fixes | ||
|
|
||
| * Replace in?, method from ActiveSupport, with include? to prevent exception "undefined method `in?`" on non-Rails app. ([#1405]) |
There was a problem hiding this comment.
Maybe place backticks around in? and include? here?
|
Oops, my bad. Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帀