feat: support alias in matcher define_enum #1419
Conversation
|
Do we have an issue related? :) |
|
Do we need one? I ran into this when I was creating some aliases for a legacy table in a database. |
|
It would be good to keep tracking and also describe what you're solving. It could be both a bugfix and a new feature. |
|
Makes sense to me. @mcmire thoughts? I can describe it on an issue if you want. |
|
This is fine. I appreciate the updates to the documentation because I could figure out pretty quickly what this was about. No need for an issue :) |
| @@ -370,7 +376,10 @@ def expected_column_type | |||
| end | |||
|
|
|||
| def column | |||
| model.columns_hash[attribute_name.to_s] | |||
| key = attribute_name.to_s | |||
| column_name = model.attribute_aliases[key] || key | |||
There was a problem hiding this comment.
It looks like attribute_aliases is not a public method in the API, but attribute_alias is: https://api.rubyonrails.org/classes/ActiveModel/AttributeMethods/ClassMethods.html#method-i-attribute_alias. What do you think about using that instead?
There was a problem hiding this comment.
I updated it. good catch! thanks
|
@mcmire would you mind reviewing it again? 😃 |
|
Sorry for the delay. I was waiting until I had confirmation on the plan for the next version, but it seems like we've got that settled now. Looks good, merging now! |
No description provided.