Fix validate_absence_of failing for array columns

[thealiilman]

My very first time contributing to this gem. 🤓 I love that the contributing guide is well-written! 🎉

This fixes #1240.

Changelog

• Made ValidatingAbsenceOfMatcher#value check whether column is array
• Added tests on array columns for ValidateAbsenceOfMatcher

[thealiilman]

Hmm, the jobs for the build on Travis CI seem to be stuck in Waiting to be queued state. Travis CI is operating though. 🤔

[mcmire]

@thealiilman Very nice, looks perfect to me! In terms of CI, Travis just implemented some changes recently to open-source projects, so it's possible that we've exceeded the limits or something. I've restarted the build to see if that helped. Once we can get this to pass, this is good to go.

[thealiilman]

@thealiilman Very nice, looks perfect to me! In terms of CI, Travis just implemented some changes recently to open-source projects, so it's possible that we've exceeded the limits or something. I've restarted the build to see if that helped. Once we can get this to pass, this is good to go.

Aha, I see. That may well be the cause.

Thanks for the approval!

[mcmire]

Merged. Thank you so much!

[vsppedro]

Thank you, @thealiilman!

@mcmire, we now have three bug fixes on the master. What do you think about a new release(v4.4.2) for them or do you have another idea in mind?

If you would like some help with that please let me know.

Bug fixes

• fix: with_foreign_key modifier fails with wrong error message #1376
• fix: actual_value_for(validate) returns false instead of true when there is no validate option #1378
• Fix validate_absence_of failing for array columns #1383

EDIT: We have the 4.5.0 Milestone and it's only missing one PR. I will try to finish it. Would you like to add anything else?

[mcmire]

@vsppedro Oops, sorry, I thought I'd already replied to this. I will hold off on merging anything else, so what we currently have in the 4.5.0 milestone looks fine to me.

I am definitely not opposed to others handling releases, so if that's something you'd like to do, then that's totally cool. Let me know and I will make sure you are able to do this. Note that I have a PR around clarifying the instructions in MAINTAINING.md around releasing so hopefully it is relatively easy to follow them once that time comes: #1384