Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Migrate to rouge [ci skip] #1343

Merged
merged 1 commit into from Sep 1, 2020

Conversation

KapilSachdev
Copy link
Collaborator

Closes #1336

@KapilSachdev KapilSachdev force-pushed the fix/migrate_to_rouge branch 2 times, most recently from 972e0a8 to d17b876 Compare August 30, 2020 10:16
Gemfile Show resolved Hide resolved
@mcmire
Copy link
Collaborator

mcmire commented Aug 31, 2020

Oops, looks like the PR I just merged created conflicts, would you mind rebasing this?

Copy link
Collaborator

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this looks good. I just tried running bundle exec yard doc and something must be screwy with the version because for some reason I'm getting docs for all of the private classes/methods instead of them being excluded. But I don't think these changes have anything to do with that, that's a separate issue.

@KapilSachdev
Copy link
Collaborator Author

@mcmire as all documentation related issues are fixed now, can you please release the missing documentation of all the versions released after 4.3.0.

@mcmire
Copy link
Collaborator

mcmire commented Sep 3, 2020

@KapilSachdev Yup! Regenerated docs for v4.4.0 and v4.4.1. If you went to http://matchers.shoulda.io/docs/ recently the redirect may be cached, but it should shortly redirect you to v4.4.1.

@VSPPedro
Copy link
Collaborator

VSPPedro commented Sep 4, 2020

What do we need to do to update the list of matchers on this page? - https://matchers.shoulda.io/

If I'm not wrong, the accept_nested_attributes_for is deprecated and because of that is not even on the README anymore.

Besides that it's missing some matchers like: have_rich_text, have_one_attached, have_many_attached, have_implicit_order_column and maybe others.

@mcmire
Copy link
Collaborator

mcmire commented Sep 4, 2020

@VSPPedro Good point! I totally forgot about that page.

The code for that page is kept in the gh-pages branch along with the documentation. I have a notice in that branch that says you shouldn't update that branch directly but in this case it would be fine. The home page is kept in index.html (sorry, I'd forgotten it's just one big HTML file — there might be a more maintainable way we can organize that code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating documentation no longer works
3 participants