Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to numericality: :other_than #1282

Merged
merged 1 commit into from Jul 23, 2020

Conversation

gmmcal
Copy link
Contributor

@gmmcal gmmcal commented Mar 21, 2020

Add support to validate numericality of a field when set :other_than comparison

@gmmcal
Copy link
Contributor Author

gmmcal commented Mar 23, 2020

Travis build has passed, but github was not properly notified =/

@guialbuk
Copy link
Collaborator

@gmmcal I'm restarting the build then 🚀

Copy link
Collaborator

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry it took me so long to review this. Thanks for updating the tests. It looks like the addition you made updated the test around combining different operators, but we still need individual tests for the other_than option. Would you mind adding that? You should be able to copy one of the existing contexts (say, is_equal_to) and then tweak it.

Copy link
Collaborator

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now! Thanks!

@mcmire mcmire merged commit a113611 into thoughtbot:master Jul 23, 2020
@mcmire mcmire mentioned this pull request Jul 25, 2020
@gmmcal gmmcal deleted the add_support_to_other_than branch August 3, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants