HaveSecureTokenMatcher: optional argument to ignore db index check #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
reviewed
Feb 21, 2020
lib/shoulda/matchers/active_record/have_secure_token_matcher.rb
Outdated
Show resolved
Hide resolved
nikosmichas
force-pushed
the
has_secure_token_matcher_optional_param
branch
from
da25e61
to
1fb1433
Compare
mcmire
approved these changes
Mar 20, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1277
has_secure_tokenencourages to use an index but does not enforce it.This PR makes the check
has_expected_db_index?optional.The default behavior is not changed.