Skip to content

Fix without_validating_presence documentation #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

berislavbabic
Copy link
Contributor

balongs_to.without_validating_presence was introduced in #1170 and both the documentation and the changelog state that the method is called without_presence_validation. Imho the implemented method name is better, so here is the documentation update, to avoid future confusion

Verified

This commit was signed with the committer’s verified signature.
berislavbabic Berislav Babic
@mcmire
Copy link
Collaborator

mcmire commented Feb 20, 2019

Whoops! Wow, I must have spaced on this when I implemented this. Good catch!

@mcmire mcmire merged commit 33ad91d into thoughtbot:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants