This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
Add support for --path option to install
#459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/neat/generator.rb
Outdated
| @install_path ||= if options[:path] | ||
| Pathname.new(File.join(options[:path], 'neat')) | ||
| else | ||
| Pathname.new('neat') |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
mehlah
force-pushed
the
install-to-custom-path
branch
from
cc0c1fd
to
97f5cf4
Compare
|
@mehlah this LGTM. Could you address the Hound hash syntax violations and rebase off of master? Then this will be good to merge. |
This allows installing Neat into a specific directory. It's more consistent with Bourbon CLI Fix thoughtbot#351
mehlah
force-pushed
the
install-to-custom-path
branch
from
97f5cf4
to
c673fd8
Compare
houndci-bot
reviewed
Jun 22, 2017
| Pathname.new(File.join(options[:path], "neat")) | ||
| else | ||
| Pathname.new("neat") | ||
| end |
There was a problem hiding this comment.
end at 59, 8 is not aligned with if at 55, 24.
| def install_path | ||
| @install_path ||= if options[:path] | ||
| Pathname.new(File.join(options[:path], "neat")) | ||
| else |
|
👋 @dgalarza! All done :) Thanks again |
|
Thanks @mehlah! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows installing Neat into a specific directory.
It's more consistent with Bourbon CLI
Fix #351