Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically create blog post PRs #1

Open
2 tasks
MatheusRich opened this issue Nov 11, 2022 · 1 comment
Open
2 tasks

Automatically create blog post PRs #1

MatheusRich opened this issue Nov 11, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MatheusRich
Copy link
Contributor

MatheusRich commented Nov 11, 2022 •
edited

At this point, GoldMiner only prints the blog post. It would be convenient if it automatically opened a draft PR with that blogpost on our blog repo.

  • PR title is New article: #{article.name}
  • PR reviewers are the people mentioned in the blogpost
@MatheusRich MatheusRich added the enhancement New feature or request label Nov 11, 2022
@MatheusRich MatheusRich mentioned this issue Nov 11, 2022
Open
MatheusRich added a commit that referenced this issue Oct 20, 2023
@MatheusRich
Introduce Gold Miner distributors
b76f0cc 
Distribution is the last step after mining and smithing gold. It's the final step,
where we deliver something useful to the world. We do that using distributor
objects.

Distributors are objects that respond to `#distribute` and perform some
kind of "delivery". For now, we have the `TerminalDistributor` which prints the
generated blog post to the terminal. I'm [planning to add] a GitHub distributor
that will open a pull request for the generated blog post.

Unlike Smiths, that take GoldContainers with GoldNuggets, I haven't found
a good abstraction for what Distributors accept. We only produce blog posts,
so I'm using that for now. It's not generic, but I'll wait until we have more
examples of distributors to find a good abstraction.

[planning to add]: #1
@MatheusRich MatheusRich mentioned this issue Oct 20, 2023
Merged
@MatheusRich MatheusRich added the good first issue Good for newcomers label Jan 19, 2024
@MatheusRich
Copy link
Contributor Author

This now can be implemented as a new distributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MatheusRich