New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes deprecation warning on linter.rb #1364

Merged

composerinteralia merged 1 commit into thoughtbot:master from RicardoTrindade:ruby-27-fix-deprecation-warning

Jan 10, 2020

Contributor

RicardoTrindade commented Jan 6, 2020

With ruby 2.7 we start seeing the following warnings when running tests

/factory_bot/lib/factory_bot.rb:74: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/factory_bot/lib/factory_bot/linter.rb:3: warning: The called method `initialize' is defined here

I'm proposing the following changes so that the message is supressed.


          fixes deprecation warning on linter.rb

38235ae

Collaborator

composerinteralia commented Jan 10, 2020

Looks good. Thanks!

composerinteralia merged commit 7f2a405 into thoughtbot:master

RicardoTrindade deleted the ruby-27-fix-deprecation-warning branch

January 10, 2020 23:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment