Raise error when a trait is self-referencing #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 3, 2019
hellosweta
force-pushed
the
ss-self-ref-trait
branch
from
e63896f
to
da5467a
Compare
houndci-bot
reviewed
May 4, 2019
hellosweta
force-pushed
the
ss-self-ref-trait
branch
2 times, most recently
from
b61d2fe
to
628579b
Compare
hellosweta
commented
May 4, 2019
hellosweta
commented
May 4, 2019
aledustet
reviewed
May 7, 2019
hellosweta
changed the title
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
hellosweta
force-pushed
the
ss-self-ref-trait
branch
2 times, most recently
from
ab10591
to
cb66970
Compare
hellosweta
force-pushed
the
ss-self-ref-trait
branch
2 times, most recently
from
a8d5729
to
70cc046
Compare
hellosweta
changed the title
pablobm
approved these changes
Sep 3, 2019
If a new trait is defined with attributes, check if attributes matches the name of the trait. Raise an error if so, to avoid a recursive call to the trait. Co-authored-by: Daniel Colsen <daniel.j.colson@thoughtbot.com> Co-authored-by: Paras Sanghavi <sanghaviparas@gmail.com>
hellosweta
force-pushed
the
ss-self-ref-trait
branch
from
70cc046
to
10e067c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to check if any attributes of a new trait definition matches the name of
the trait. Raise an error if so, to avoid a recursive call to the trait. A fix to:
#1238