Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence gem list command output #181

Merged

Conversation

tagliala
Copy link
Contributor

Prevents appraisal rake to write a boolean on the standard output when
checking the installed version of bundler

Bug introduced in #168 5868643

Fix: #180

Prevents `appraisal rake` to write a boolean on the standard output when
checking the installed version of bundler

Bug introduced in thoughtbot#168 5868643

Fix: thoughtbot#180
@tagliala
Copy link
Contributor Author

CI Failure looks unrelated to me and the main branch is also failing against JRuby

@tagliala tagliala marked this pull request as ready for review March 28, 2021 12:17
@nickcharlton
Copy link
Member

Ah hah! Nice one. Thank you for opening this. I'm going to ignore JRuby for now but with the rest passing that's good enough.

@nickcharlton nickcharlton merged commit cf7ea9a into thoughtbot:master May 10, 2021
@tagliala tagliala deleted the bugfix/silence-gemlist-output branch May 10, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appraisal >= 2.3.0 outputs "true" to console (PR attached)
2 participants