From bcb6d1a324fca664c5e9f001aab6c2ed0acb8691 Mon Sep 17 00:00:00 2001 From: Andre Anastacio Date: Sun, 2 Jul 2017 00:44:01 -0300 Subject: [PATCH] Remove NameError rescue in page base --- lib/administrate/page/base.rb | 2 -- .../db/migrate/20170702033920_add_timestamp_to_payments.rb | 5 +++++ spec/example_app/db/schema.rb | 4 +++- 3 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 spec/example_app/db/migrate/20170702033920_add_timestamp_to_payments.rb diff --git a/lib/administrate/page/base.rb b/lib/administrate/page/base.rb index 00770ead69..34d296b57f 100644 --- a/lib/administrate/page/base.rb +++ b/lib/administrate/page/base.rb @@ -25,8 +25,6 @@ def attribute_field(dashboard, resource, attribute_name, page) def get_attribute_value(resource, attribute_name) resource.public_send(attribute_name) - rescue NameError - nil end attr_reader :dashboard, :options diff --git a/spec/example_app/db/migrate/20170702033920_add_timestamp_to_payments.rb b/spec/example_app/db/migrate/20170702033920_add_timestamp_to_payments.rb new file mode 100644 index 0000000000..c2d0baff22 --- /dev/null +++ b/spec/example_app/db/migrate/20170702033920_add_timestamp_to_payments.rb @@ -0,0 +1,5 @@ +class AddTimestampToPayments < ActiveRecord::Migration[5.1] + def change + change_table(:payments, &:timestamps) + end +end diff --git a/spec/example_app/db/schema.rb b/spec/example_app/db/schema.rb index 9b6eb5ad83..f244a75c29 100644 --- a/spec/example_app/db/schema.rb +++ b/spec/example_app/db/schema.rb @@ -10,7 +10,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema.define(version: 20170507115814) do +ActiveRecord::Schema.define(version: 20170702033920) do # These are extensions that must be enabled in order to support this database enable_extension "plpgsql" @@ -58,6 +58,8 @@ create_table "payments", id: :serial, force: :cascade do |t| t.integer "order_id" + t.datetime "created_at", null: false + t.datetime "updated_at", null: false t.index ["order_id"], name: "index_payments_on_order_id" end