From cd1492a20aca252e1b3ea356d808e0d916ad6439 Mon Sep 17 00:00:00 2001 From: Pablo Brasero Date: Mon, 23 Dec 2019 22:35:43 +0000 Subject: [PATCH] Remove query from link, to avoid triggering banned params --- .../javascripts/administrate/components/table.js | 2 +- spec/features/index_page_spec.rb | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/administrate/components/table.js b/app/assets/javascripts/administrate/components/table.js index 81be98358d..493e691bce 100644 --- a/app/assets/javascripts/administrate/components/table.js +++ b/app/assets/javascripts/administrate/components/table.js @@ -13,7 +13,7 @@ $(function() { var dataUrl = $(event.target).closest("tr").data("url"); var selection = window.getSelection().toString(); if (selection.length === 0 && dataUrl) { - window.location.pathname = dataUrl; + window.location = window.location.protocol + '//' + window.location.host + dataUrl; } } }; diff --git a/spec/features/index_page_spec.rb b/spec/features/index_page_spec.rb index 57b181a6b1..faa8880cfc 100644 --- a/spec/features/index_page_spec.rb +++ b/spec/features/index_page_spec.rb @@ -95,6 +95,16 @@ def expect_to_appear_in_order(*elements) expect_to_appear_in_order("unique name one", "unique name two") end + it "allows clicking through after sorting", :js do + customer = create(:customer) + create(:order, customer: customer) + + visit admin_customers_path + click_on "Name" + find("[data-url]").click + expect(page).to have_header("Show #{customer.name}") + end + it "allows reverse sorting" do create(:customer, name: "unique name one") create(:customer, name: "unique name two")