From f71a3bff2e5847c50181d01de2d47b868b050e62 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Thu, 24 Oct 2019 03:03:57 +0000 Subject: [PATCH 1/3] [Security] Bump loofah from 2.3.0 to 2.3.1 Bumps [loofah](https://github.com/flavorjones/loofah) from 2.3.0 to 2.3.1. **This update includes a security fix.** - [Release notes](https://github.com/flavorjones/loofah/releases) - [Changelog](https://github.com/flavorjones/loofah/blob/master/CHANGELOG.md) - [Commits](https://github.com/flavorjones/loofah/compare/v2.3.0...v2.3.1) Signed-off-by: dependabot-preview[bot] --- Gemfile.lock | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 7f452b1bfe..8f4d382433 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -74,7 +74,7 @@ GEM concurrent-ruby (1.1.5) crack (0.4.3) safe_yaml (~> 1.0.0) - crass (1.0.4) + crass (1.0.5) database_cleaner (1.7.0) datetime_picker_rails (0.0.7) momentjs-rails (>= 2.8.1) @@ -134,7 +134,7 @@ GEM kgio (2.11.2) launchy (2.4.3) addressable (~> 2.3) - loofah (2.3.0) + loofah (2.3.1) crass (~> 1.0.2) nokogiri (>= 1.5.9) method_source (0.9.2) From 191655b6aa42a3022da0e4d5761b7eb069bb8fa2 Mon Sep 17 00:00:00 2001 From: Pablo Brasero Date: Fri, 25 Oct 2019 10:11:54 +0100 Subject: [PATCH 2/3] Required by Sprockets 4 --- spec/example_app/app/assets/config/manifest.js | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 spec/example_app/app/assets/config/manifest.js diff --git a/spec/example_app/app/assets/config/manifest.js b/spec/example_app/app/assets/config/manifest.js new file mode 100644 index 0000000000..a859a4a9d4 --- /dev/null +++ b/spec/example_app/app/assets/config/manifest.js @@ -0,0 +1,2 @@ +//= link administrate/application.css +//= link administrate/application.js From 36c573404a7d9beb7e0903745acdc85d4fe7476a Mon Sep 17 00:00:00 2001 From: Pablo Brasero Date: Fri, 25 Oct 2019 18:16:58 +0100 Subject: [PATCH 3/3] Explain issue. Include error for SEO --- README.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/README.md b/README.md index 59bbabaed6..f4908d327e 100644 --- a/README.md +++ b/README.md @@ -64,6 +64,21 @@ to see your new dashboard in action. For more detailed instructions or to make it work with Rails API-only applications, please go through the ['Getting Started` guide](https://administrate-prototype.herokuapp.com/getting_started). +If your apps uses Sprockets 4, you'll need to add Administrate's assets to your `manifest.js` file. To do this, add these two lines to the file: + +``` +//= link administrate/application.css +//= link administrate/application.js +``` + +Otherwise, your app will show you this error: + +``` +Asset `administrate/application.css` was not declared to be precompiled in production. +Declare links to your assets in `app/assets/config/manifest.js`. +``` + +For more information on why this is necessary, see https://www.schneems.com/2017/11/22/self-hosted-config-introducing-the-sprockets-manifestjs ## Create Additional Dashboards