Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the removal of the transitive sprockets-rails dependency #2514

Open
seanpdoyle opened this issue Feb 13, 2024 · 0 comments · May be fixed by #2518
Open

Document the removal of the transitive sprockets-rails dependency #2514

seanpdoyle opened this issue Feb 13, 2024 · 0 comments · May be fixed by #2518
Labels
bug breakages in functionality that is implemented

Comments

@seanpdoyle
Copy link
Contributor

  • What were you trying to do?

Upgrade from 0.18.0 to 1.0.0.beta1

  • What did you end up with (logs, or, even better, example apps are great!)?

Our application depends on propshaft@0.8.0 for assets. Depending on administrate brought along an additional transitive dependency on sprockets-rails@3.4.2.

The removal of the transitive sprockets-rails dependency in the latest beta release somehow broke our application's integration with inline_svg (outside of the Administrate engine). By restoring the dependency as a direct, explicit Gemfile declaration, SVG asset resolution was restored.

  • What versions are you running?
    • Rails 7.1.3
    • administrate 0.18.0 upgraded to 1.0.0.beta1
@seanpdoyle seanpdoyle added the bug breakages in functionality that is implemented label Feb 13, 2024
nickcharlton added a commit that referenced this issue Feb 14, 2024
@nickcharlton
Add a guide for Migrating to v1
ee01cbd 
This intends to document everything we've heard as reported issues, to
try and help users migrate as easily as possible.

It will collect a few issues before being merged, but this started with
documenting the transitive dependency on `sprockets-rails`.

Closes #2514
@nickcharlton nickcharlton linked a pull request Feb 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug breakages in functionality that is implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a guide for Migrating to v1 thoughtbot/administrate
1 participant
@seanpdoyle