Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to app not translated #1622

Closed
betelgeuse opened this issue Apr 24, 2020 · 11 comments · Fixed by #1651
Closed

Back to app not translated #1622

betelgeuse opened this issue Apr 24, 2020 · 11 comments · Fixed by #1651
Labels
bug breakages in functionality that is implemented i18n translations and language support

Comments

@betelgeuse
Copy link
Contributor

  • What were you trying to do?
    Use administrate with locale different from English
  • What did you end up with (logs, or, even better, example apps are great!)?
    Not being able to translate "Back to app"
  • What versions are you running?
    master of administrate

The code added in #1376 is missing i18n keys.

@betelgeuse betelgeuse added the bug breakages in functionality that is implemented label Apr 24, 2020
@nickcharlton nickcharlton added the i18n translations and language support label Apr 29, 2020
@nickcharlton
Copy link
Member

Nice catch! I clearly didn't think about that at the time.

Would you be able to open a PR for this?

@betelgeuse
Copy link
Contributor Author

Would you be able to open a PR for this?

Is there a better way than Google translate to come up with the required translations?

@nickcharlton
Copy link
Member

Unfortunately, this is basically what I'd been doing. The other option is to add them in English to all of the translation files, but that's not great either.

In general, I've found people will open PRs to fix translations if they're not very good and so I've been relying on that.

@betelgeuse
Copy link
Contributor Author

The other option is to add them in English to all of the translation files, but that's not great either.

Adding in English would prevent tools that spot missing translations from working so I would avoid it as an option.

@pablobm
Copy link
Collaborator

pablobm commented May 1, 2020

How about this plan:

  1. @betelgeuse creates a PR with the English string and any other languages you may know.
  2. We can then ask around people we know for other common languages and add them to the PR.
  3. When we feel we have covered some reasonable defaults, we can merge.

I'm not sure how a missing translation would affect people though. I just tried running the example app in Spanish and got an error translation missing: es.views.pagination.next. From this, I'm thinking that people are used to providing missing strings as soon as they see errors. If this is the case, we should be ok.

Thoughts?

@nickcharlton
Copy link
Member

I think working with errors is an acceptable trade off, to encourage translation contributions.

@betelgeuse
Copy link
Contributor Author

I think working with errors is an acceptable trade off, to encourage translation contributions.

Should probably have a README entry saying not to expect locale files to be perfect.

@edimossilva
Copy link
Contributor

How about this plan:

  1. @betelgeuse creates a PR with the English string and any other languages you may know.
  2. We can then ask around people we know for other common languages and add them to the PR.
  3. When we feel we have covered some reasonable defaults, we can merge.

I'm not sure how a missing translation would affect people though. I just tried running the example app in Spanish and got an error translation missing: es.views.pagination.next. From this, I'm thinking that people are used to providing missing strings as soon as they see errors. If this is the case, we should be ok.

Thoughts?

So @pablobm, I also had the same issue in portuguese, it is due to Kaminari Showing /var/lib/gems/2.5.0/gems/kaminari-core-1.2.0/app/views/kaminari/_next_page.html.erb, they don't have the proper translations :(

We have 2 options:

  1. solve this issue on kaminari
  2. solve it here ( doesn't look a smart choice) creating files like kaminari.pt-BR.yml with content similar to:
pt-BR:
  views:
    pagination:
      first: "« Primeiro"
      last: "Ultimo »"
      previous: "‹ Anterior"
      next: "Proximo ›"
      truncate: "..."

@pablobm
Copy link
Collaborator

pablobm commented May 21, 2020

@betelgeuse - I agree with adding that note to the README.

@edimossilva - From what I see on the Kaminari repo, they don't appear to provide translations for any language. It looks to me as though they expect each application to provide their own. In this case, we'll have to provide it ourselves.

@edimossilva
Copy link
Contributor

@pablobm, so should I create another issue related to kaminari translations?

@pablobm
Copy link
Collaborator

pablobm commented May 22, 2020

@edimossilva - Yes, I think that opening a separate issue would be the right approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug breakages in functionality that is implemented i18n translations and language support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants