Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix very narrow nested fields #1561

Merged
merged 2 commits into from Mar 5, 2020
Merged

Fix very narrow nested fields #1561

merged 2 commits into from Mar 5, 2020

Conversation

sedubois
Copy link
Contributor

@sedubois sedubois commented Feb 26, 2020

I am not especially talented at CSS, but here is a fix for the very narrow layout which makes editing bigger nested fields such as textareas very impractical.

Before:
before

After:
after

The problem can also be seen on http://administrate-prototype.herokuapp.com/admin/products when editing some product (product meta tag meta title and meta description are very narrow, which would be problematic if those fields were textareas).

Screenshot 2020-02-26 at 18 47 43

@pablobm
Copy link
Collaborator

pablobm commented Mar 5, 2020

I like your approach of max-widths based on rems rather than percentages. Thank you.

@pablobm pablobm merged commit 7546a4b into thoughtbot:master Mar 5, 2020
@pablobm
Copy link
Collaborator

pablobm commented Mar 5, 2020

Hm, I just noticed that the resulting commit of my merge was attributed to me instead of you. I guess it's because it was a squash commit...? Apologies for that. I'll ask.

@sedubois
Copy link
Contributor Author

sedubois commented Mar 5, 2020

Thanks @pablobm, yes a squash would be a new commit, which seems correct to me. Thanks for merging 👍

@nickcharlton nickcharlton added fields new fields, displaying and editing data views-and-styles how administrate looks and is interacted with labels Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fields new fields, displaying and editing data views-and-styles how administrate looks and is interacted with
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants