New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide <title> tags for doc pages #1537
Conversation
e11a455
to
bf010f7
Compare
Oh that's a bit exciting. The only alternative I can think of is to add something like YAML front matter, so each Markdown file would have something like: ---
title: The Page Title
--- What do you think? |
Yes, I think that's worth looking into. I have given it a go at master...pablobm:frontmatter, which builds on top of this PR. However I have noticed one snag. Currently, we include the contributing guide from the documentation, as a symlink to the standard one that you can normally read on GitHub. The snag is that this page now has to choose to either show the main title as a markdown What do you think? |
I think whilst having a box above the top is a bit strange, it doesn't really matter in the hope of making everything look good on the docs site (somewhere we control, rather than GitHub) |
bf010f7
to
8710d09
Compare
Sounds good 👍 I incorporated the Frontmatter changes on this PR now. |
I deployed a review app so we can take a look at it: https://administrate-demo-prer-pr-1537.herokuapp.com/ |
Two quick thoughts:
|
I agree on both. Also a third one: the pages have now lost their Working on it. |
OK, first weird thing: the index page is the readme, so now we have the Frontmatter table on the project's home page on GitHub. I think this is more awkward than the previous situation with the contributing page. What do you think? |
Addressed all three issues. (By the way, if at some point you think my initial proposal was better, that's fine. I'm not very attached to this code. It's a useful experiment.) |
Huh nice. Omg, how is this such a difficult problem! We're in a much better state than we were, but let me think about it a bit next |
Yeah, who would have thought! 😄 No worries. |
I think this is the best approach, so I'm going to merge it. Thanks! |
The lack of <title> tags may be harming SEO (I'm thinking of people looking for Administrate's documentation).
There's also the matter that each page has two
h1
s, but that's another matter and can be treated separately.Admittedly, my solution is a bit dirty. Is it worth my spending a bit more time to make it more presentable? Do you have any ideas?