Remove project level rubocop.yml #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubocop brings with it a certain amount of maintenence burden and keeping project level config files means they're always somewhat out of date. Additionally, we already have [thoughtbot/guides][one] which is the source of truth. This removes that to see if we get the right outcome. [one]: https://github.com/thoughtbot/guides/blob/master/style/ruby/.rubocop.yml
nickcharlton
added
dependencies
|
@nickcharlton will this change mean hound won't be able to post suggestions to ruby code? Would that be a desirable outcome given that this project receives quite a lot of PRs? |
|
Thankfully, no. Hound supports an organisation wide configuration:
The one thing I did notice that we do do in our local AllCops:
Exclude:
- spec/example_app/db/schema.rb…which means that now we'd likely get complaints by Rubocop as it won't be ignored. But I think this is a small price to pay for not having another configuration file. |
|
Thanks for the insight, that was a great explanation. I completely agree with you. |
jmeinerz
approved these changes
Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop brings with it a certain amount of maintenence burden and
keeping project level config files means they're always somewhat out of date.
Additionally, we already have thoughtbot/guides which is the
source of truth.
This removes that to see if we get the right outcome.