Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose required fields on form #1521

Merged

Conversation

davi-tapajos-codeminer42
Copy link
Contributor

@davi-tapajos-codeminer42 davi-tapajos-codeminer42 commented Jan 10, 2020

Displays an asterisk beside label on form when field is required

Issue: #1489

Captura de Tela 2020-01-09 às 17 20 38

@marclerodrigues
Copy link

Overall it looks really good.

@hound hound bot deleted a comment from davi-tapajos-codeminer42 Jan 23, 2020
@hound hound bot deleted a comment from pablobm Jan 23, 2020
@pablobm pablobm merged commit b9a6d6d into thoughtbot:master Jan 25, 2020
@pablobm
Copy link
Collaborator

pablobm commented Jan 25, 2020

Thank you for your contribution @davi-tapajos-codeminer42!

@sedubois
Copy link
Contributor

NB: this marks fields as required even when the validation is not applied due to an if/unless:

  validates :amount, :currency, presence: true, if: ->{ stripe? }

Screenshot 2020-10-14 at 18 11 58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants