Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should be possible to run every spec individually #1475

Merged
merged 1 commit into from Dec 27, 2019

Conversation

pablobm
Copy link
Collaborator

@pablobm pablobm commented Nov 29, 2019

I noticed that some specs can't be run individually, as their dependencies are not correct. This can become rather inconvenient while debugging Administrate. This PR fixes this issue.

A way to check that specs run individually is with the following one-liner:

$ find spec | grep _spec.rb | while read spec; do bundle exec rspec $spec; done

This includes some changes that are not really necessary, but I think make the specs make more sense. I'm referring mainly to things like spec/generators/assets/javascripts_generator_spec.rb, where I make sure that support/generator_spec_helpers is required before the tested code, because I feel that the helpers should be loaded first (like spec_helper or rails_helper) are.

@nickcharlton
Copy link
Member

Checks out! Thank you.

@nickcharlton nickcharlton merged commit 4d9b0ee into thoughtbot:master Dec 27, 2019
@pablobm pablobm deleted the run-individual-specs branch June 24, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants