Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade actix packages once actix-web v4 is released as stable #356

Closed
rhigman opened this issue Feb 25, 2022 · 2 comments · Fixed by #373
Closed

Upgrade actix packages once actix-web v4 is released as stable #356

rhigman opened this issue Feb 25, 2022 · 2 comments · Fixed by #373
Assignees
@rhigman
Projects
Thoth

Comments

@rhigman
Copy link
Member

rhigman commented Feb 25, 2022

As noted in #355 and actix/actix-web#2664, actix package code dependencies will start causing build failures in a future version of Rust. Before/when this happens, we will need to upgrade actix (currently on actix-web 3.3.2, issue is fixed in actix-web 4.0.0 which is still in beta).
@rhigman
Copy link
Member Author

rhigman commented Feb 28, 2022

actix-web 4.0.0 has now been released, but actix-identity does not yet have a stable version with the fixed dependencies. Progress once this is released (begun on branch feature/356_actix_v4).

@rhigman
Copy link
Member Author

rhigman commented Mar 1, 2022

actix-identity 0.4.0 is now out and fixes the dependency. To fully remove the outdated actix-web 3.3.2 package, we will need to upgrade paperclip when it is next released (should be soon - see paperclip-rs/paperclip#314).

@rhigman rhigman self-assigned this Mar 2, 2022
@rhigman rhigman added this to Backlog in Thoth via automation Mar 2, 2022
@rhigman rhigman moved this from Backlog to In progress in Thoth Mar 2, 2022
@rhigman rhigman moved this from In progress to To do in Thoth Mar 2, 2022
@rhigman rhigman mentioned this issue Apr 26, 2022
Merged
@rhigman rhigman moved this from To do to In progress in Thoth Apr 27, 2022
@rhigman rhigman linked a pull request Apr 27, 2022 that will close this issue
Upgrade actix-web to v4 to remove dependency on outdated package time-macros-impl (#356) #373
Merged
rhigman added a commit that referenced this issue May 11, 2022
@rhigman
Merge pull request #373 from thoth-pub/feature/356_actix_v4
89a57e3 
Upgrade actix-web to v4 to remove dependency on outdated package time-macros-impl (#356)
@rhigman rhigman closed this as completed May 11, 2022
Thoth automation moved this from In progress to Done May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhigman rhigman

Labels
None yet
Projects
No open projects
Thoth
  
Done
Milestone
No milestone
1 participant
@rhigman