Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show received addresses in icmp_replies (especially for broadcast pings) #38

Closed
vi opened this issue Nov 18, 2020 · 1 comment
Closed
Assignees

Comments

@vi
Copy link

vi commented Nov 18, 2020

icmp_replies section seems to omit the actual address it received a reply from.

For example, from this input:

PING ff02::2%usb0(ff02::2%usb0) 56 data bytes
64 bytes from fe80::783c:caff:fe12:b46c%usb0: icmp_seq=1 ttl=64 time=2.71 ms

--- ff02::2%usb0 ping statistics ---
1 packets transmitted, 1 received, 0% packet loss, time 0ms
rtt min/avg/max/mdev = 2.708/2.708/2.708/0.000 ms

I get approximately this output:

{
    "destination": "ff02::2%usb0",
    "packet_transmit": 1,
    "packet_receive": 1,
    "packet_loss_count": 0,
    "packet_loss_rate": 0.0,
    "rtt_min": 7.222,
    "rtt_avg": 7.222,
    "rtt_max": 7.222,
    "rtt_mdev": 0.0,
    "packet_duplicate_count": 0,
    "packet_duplicate_rate": 0.0,
    "icmp_replies": [
        {
            "icmp_seq": 1,
            "ttl": 64,
            "time": 7.22,
            "duplicate": false
        }
    ]
}

The point is extracting that fe80::783c:caff:fe12:b46c,which is missing in the output.

@thombashi
Copy link
Owner

Thank you for your feedback.
Received addresses will be shown in icmp_replies with pingparsing 1.3.0 or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants