Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show packet size #35

Closed
cloudprodz opened this issue May 5, 2020 · 1 comment
Closed

Show packet size #35

cloudprodz opened this issue May 5, 2020 · 1 comment
Assignees
@thombashi
Labels
enhancement

Comments

@cloudprodz
Copy link

cloudprodz commented May 5, 2020 •
edited

Current json output does not show ping packet size (either with or without ICMP/IP headers) even though the command accepts the parameter.
for example with -s 1472 json output could show:
"icmp_payload_size": 1472,
thombashi added a commit that referenced this issue Mar 27, 2021
@thombashi
Add packet size in icmp_replies: #35
5059673
@thombashi thombashi self-assigned this Mar 27, 2021
@thombashi
Copy link
Owner

Thank you for your feedback.
bytes will be shown in icmp_replies with pingparsing 1.3.0 or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thombashi thombashi

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thombashi @cloudprodz