New tag argument to control prefix of version #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
approved these changes
Oct 6, 2021
h4sh3d
force-pushed
the
add-tag-argument
branch
2 times, most recently
from
048580b
to
7e9f6cc
Compare
Add an new input `tag` and remove `version` as required option to allow smooth transition to the new `tag` argument later. If tag is set version argument is ignored, if version argument is set a warning is emitted to transition to tag and tag is set to its value. Internally tag is added along version to differentiate the version (strict semver) and the tag (potentially 'v' prefixed semver). If the tag is prefixed, version is set as the non-prefixed tag value.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10
Add an new input
tagand removeversionas required option to allowsmooth transition to the new
tagargument later. If tag is set versionargument is ignored, if version argument is set a warning is emitted to
transition to tag and tag is set to its value.
Internally tag is added along version to differentiate the version
(strict semver) and the tag (potentially 'v' prefixed semver). If the
tag is prefixed, version is set as the non-prefixed tag value.