Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor ignore in setup.cfg / tox.ini #30

Closed
brianbruggeman opened this issue Sep 13, 2017 · 5 comments
Closed

Honor ignore in setup.cfg / tox.ini #30

brianbruggeman opened this issue Sep 13, 2017 · 5 comments
Labels
duplicate question

Comments

@brianbruggeman
Copy link
Contributor

Currently pytest-flake8 will ignore/override the standard [flake8] ignore section even if flake8-ignore is not present within the [tool:pytest] section. The default behavior should be to honor the settings in the [flake8] section within setup.cfg or tox.ini.
brianbruggeman added a commit to brianbruggeman/pytest-flake8 that referenced this issue Sep 13, 2017
@brianbruggeman
Pytest-Flake8 now honores ignore settings in default Flake8 Config Se…
cb03141 
…ction

* Fixes issue tholo#30
* Adds a test with a flake8 section
* Adds a simple if statement to control overwrites on ignores
@brianbruggeman brianbruggeman mentioned this issue Sep 13, 2017
Merged
@mikemill mikemill mentioned this issue Oct 2, 2017
Closed
@tholo
Copy link
Owner

tholo commented Oct 24, 2017

I think this was corrected in #21

@brianbruggeman
Copy link
Contributor Author

Cool. Thanks! Is this in the latest release on Pypi (it looks like it was most recently updated in the last 24 hours)?

From a review standpoint, I would have probably added a test or two to validate.

@brianbruggeman
Copy link
Contributor Author

Having tested the solution in #21 with a project I'm working on... I don't think it fixes the issue and I think it may break things.

I have an alternative fix here: #31

@henning
Copy link

henning commented Feb 27, 2018

Having this issue too and I was about to file a bug.

Currently the only way to commonly ignore some kinds of errors (e.g. style problems in django-generated migrations) independent of wether flake8 is run directly or via pytest is to annotate/comment in the files directly.

I'd stringly prefer that I can configure all flake8 stuff in a pytest independent way so however flake8 is run later, it will be configured correctly.

@artiemq
Copy link
Contributor

artiemq commented Mar 1, 2018

Fixed in #31

@artiemq artiemq closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@henning @tholo @brianbruggeman @artiemq