fix: Only consider pointer to structs when checking for embedded fields #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the trouble but I've noticed this in our CI tests after updating to
go-funk
version with my fix.This is a follow up to #159
We should only consider pointer to structs when looking at embedded structs, as non pointers can never be
nil
.The previous code would panic on structs since I used
IsNil
which can only called on pointers to structs.This fixes the issue and adds a test to catch the previous panic