Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoveTargetsWithExpires does not pin to a preferred delegation #400

Closed
asraa opened this issue Sep 28, 2022 · 1 comment
Closed

RemoveTargetsWithExpires does not pin to a preferred delegation #400

asraa opened this issue Sep 28, 2022 · 1 comment

Comments

@asraa
Copy link
Contributor

asraa commented Sep 28, 2022

repo.RemoveTargetsWithExpires will remove a target from ALL delegated target metadata: there is no way to specify a certain targets or delegation role.

This means that if a delegation had signed off on the same path as another (allowed), or one of top-level that takes precedence, then removing the target in the delegaiton (intended) will remove it everywhere.

cc @joshuagl detected this in sigstore root-signing
sigstore/root-signing#410

@rdimitrov
Copy link
Contributor

Closing since the code base changed and this is no longer valid.

Thanks for raising this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants