build: Use Go 1.17 for golangci linting and update golangci/golangci-lint-action #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethan-lowman-dd
force-pushed
the
ethan.lowman/fix-linters-go-1.18
branch
from
35ef54e
to
88b6bc1
Compare
asraa
reviewed
Aug 24, 2022
ethan-lowman-dd
force-pushed
the
ethan.lowman/fix-linters-go-1.18
branch
2 times, most recently
from
a11e9a0
to
ca0eb4e
Compare
asraa
reviewed
Aug 24, 2022
asraa
reviewed
Aug 24, 2022
asraa
previously approved these changes
Aug 24, 2022
trishankatdatadog
previously approved these changes
Aug 24, 2022
asraa
previously approved these changes
Aug 29, 2022
|
@ethan-lowman-dd would you mind resolving the conflicts? |
…tion Go 1.18 is not supported by golangci-lint yet since generics are not supported. Signed-off-by: Ethan Lowman <ethan.lowman@datadoghq.com>
Signed-off-by: Ethan Lowman <ethan.lowman@datadoghq.com>
Signed-off-by: Ethan Lowman <ethan.lowman@datadoghq.com>
Signed-off-by: Ethan Lowman <ethan.lowman@datadoghq.com>
Signed-off-by: Ethan Lowman <ethan.lowman@datadoghq.com>
Signed-off-by: Ethan Lowman <ethan.lowman@datadoghq.com>
Signed-off-by: Ethan Lowman <ethan.lowman@datadoghq.com>
Signed-off-by: Ethan Lowman <ethan.lowman@datadoghq.com>
ethan-lowman-dd
dismissed stale reviews from asraa and trishankatdatadog
via
ae1bd4e
ethan-lowman-dd
force-pushed
the
ethan.lowman/fix-linters-go-1.18
branch
from
5c04ac0
to
ae1bd4e
Compare
|
Rebased the branch to fix merge conflicts. |
trishankatdatadog
approved these changes
Sep 6, 2022
asraa
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #362
Release Notes:
Types of changes:
Description of the changes being introduced by the pull request:
Go 1.18 is not supported by golangci-lint yet since generics are not supported. To fix, we have to lint using Go 1.17. Note that gofmt checks still appear to target the latest Go version.
Please verify and check that the pull request fulfills the following requirements: