fix: add leveldb recover ability #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While fixing theupdateframework#349, the leveldb supports a Recover() method in case the manifest is broken. I validated that the Recover would have recovered the manifest file using the db file (that still existed). Add a test that validates if the manifest is truncated, it can be recovered. Signed-off-by: Mike Marchetti <mike@agilicus.com>
|
Shouldn't there be an option to merge/rebase with the base branch from the GitHub UI? I don't see it here, which is a shame, bcos we have to wait for @mfmarche to do it manually for us. |
znewman01
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing #349, the leveldb supports a Recover() method in case the
manifest is broken. I validated that the Recover would have recovered
the manifest file using the db file (that still existed). Add a test
that validates if the manifest is truncated, it can be recovered.
Signed-off-by: Mike Marchetti mike@agilicus.com
Please fill in the fields below to submit a pull request. The more information that is provided, the better.
Fixes #
Release Notes:
Types of changes:
Description of the changes being introduced by the pull request:
Please verify and check that the pull request fulfills the following requirements: